Changeset 1286

Show
Ignore:
Timestamp:
02/28/08 11:22:43 (6 months ago)
Author:
kindlund
Message:

Added additional error checking.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • honeyclient/trunk/lib/HoneyClient/Manager/Database.pm

    r1251 r1286  
    222222 
    223223    # Perform the RPC call. 
    224     # XXX: Externalize this URL. 
    225224    my $xmlrpc = XML::RPC->new(getVar(name => "url")); 
    226     #my $xmlrpc = XML::RPC->new('http://172.16.164.103:3000/hc_database/api'); 
    227     #my $ret = $xmlrpc->call($name,$obj_yaml); 
    228     my $ret = $xmlrpc->call($name,@_); 
     225    my $ret = undef; 
     226    
     227    eval { 
     228        $ret = $xmlrpc->call($name,@_); 
     229    }; 
     230 
     231    # Error checking. 
     232    if ($@ || !defined($ret)) { 
     233        $LOG->error("Error: RPC communications failure."); 
     234        Carp::croak("Error: RPC communications failure."); 
     235    } 
    229236 
    230237    # Error checking. 
    231238    if ((ref($ret) eq "HASH") && (exists($ret->{faultCode}))) { 
    232         # XXX: Log this error. 
     239        $LOG->error("Error: " . $ret->{faultString}); 
    233240        Carp::croak("Error: " . $ret->{faultString}); 
    234241    }